Draft
Conversation
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 270 270
Lines 11913 11913
Branches 103 103
=======================================
Hits 11689 11689
Misses 224 224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seqan-actions
added
lint
Member
|
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage:
seqan3::sequence_file_output fout{"/tmp/test.sam", seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{}, std::ios_base::app};Old
Example usage:
seqan3::sequence_file_output fout{"/tmp/test.sam", seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{}, {.append = true}};sequence_file_output_optionsfor this because I didn't want to add another enum/strong type. We could also do an enum or a bool. Or even astd::ios_base::openmode(with constraints?).sequence_file_output_options::appendis the only option that's fixed on constructionseqan3::sequence_file_output fout{"/tmp/test.sam", seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{}, {.append = true}}; fout.options.append = false; // No effectseqan3::sequence_file_output fout{"/tmp/test.sam", seqan3::fields<seqan3::field::id, seqan3::field::seq, seqan3::field::qual>{}}; fout.options.append = true; // No effect